Added option for uploading extension file for client/server environments #129
Conversation
puneet0191
left a comment
puneet0191
left a comment
There was a problem hiding this comment.
Looks good to me, we could have provided the file path usage as a comment, to avoid the confusion of what we meant by _data folder, although it is clear. Thanks 😄
|
Fixed (and added cs too) |
|
Thanks 👍 |
|
@yvesh I will be merging this one, Please review..I have tested the code on my local machine. |
|
@puneet0191 sure, fine for me. I am not sure why we have to output the extension type (some are also missing), but rest looks fine :-) |
|
About the extension, it's because Joomla outputs different messages depending on the extension types. I can't recall if there are other messages out of those 3 so I think that's it. I'm going to merge this since I'm ok with it too. |
|
Nevermind, there are new cs errors :) can't merge even with the approval, so I'll fix |
|
Replaced by #138 |
3 participants
No description provided.