[Fix] doFrontendLogout() #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes redirect issue after logging out in J3.7.x
Contributor
Author
|
Not sure why my last commit got into this one, sorry about that, hope doesn't affect anything. |
Contributor
|
Thanks for the provided update @vortrixs @puneet0191 could you take it? |
Member
|
I will take it. thanks @vortrixs |
Member
|
I have verified this patch, here is the result. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When logging out in J3.7.x it redirects to
index.php/en/instead of the user login view causing the test to fail.To fix this we go back to the login view after logging out, then check if the login form is shown just as before