fixes the multi language install process. #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Is not this change also necessary in the develop branch? |
Contributor
Author
|
If you apply the dev branch on Joomla 3.7: no. That would break the setup. |
Contributor
|
@svenbluege Thank you for your answer. @ALL Shall we open a separate branch for 3.7 in this case? |
Member
|
@astridx Yes Develop Branch is always the latest, and I think these changes should also be applied to develop branch. We do not have any new 3.7.x release coming up, so I am sure we can merge these changes to develop now. |
Contributor
|
@puneet0191 Do we need to create a tag/releas for Joomla version 3.7 before we merge these changes? |
Member
|
Thanks @svenbluege |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the multi language install process. Again ;)