Skip to content

Passing String instead of Array to Assert functions #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2018
Merged

Passing String instead of Array to Assert functions #166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/JoomlaBrowser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ public function installJoomlaRemovingInstallationFolder($databaseName = null, $d
$this->waitForJS("return jQuery('form#adminForm input[name=instDefault]').attr('disabled') == 'disabled';", TIMEOUT);

$this->debug('Joomla is now installed');
$this->see('Congratulations! Joomla! is now installed.', ['xpath' => '//h3']);
$this->see('Congratulations! Joomla! is now installed.', '//h3');
}

/**
Expand Down Expand Up @@ -374,7 +374,7 @@ public function installJoomlaMultilingualSite($languages = array(), $databaseNam
$this->wait(2);

$this->debug('Joomla is now installed');
$this->see('Congratulations! Joomla! is now installed.', ['xpath' => '//h3']);
$this->see('Congratulations! Joomla! is now installed.', '//h3');
}

/**
Expand All @@ -399,7 +399,7 @@ public function setErrorReportingToDevelopment()
$this->click(['xpath' => "//div[@id='toolbar-apply']//button"]);
$this->debug('I wait for global configuration being saved');
$this->waitForText('Global Configuration', TIMEOUT, ['css' => '.page-title']);
$this->see('Configuration saved.', ['id' => 'system-message-container']);
$this->see('Configuration saved.', '#system-message-container');
}

/**
Expand Down Expand Up @@ -727,7 +727,7 @@ public function enablePlugin($pluginName)
$this->checkExistenceOf($pluginName);
$this->click(['xpath' => "//input[@id='cb0']"]);
$this->click(['xpath' => "//div[@id='toolbar-publish']/button"]);
$this->see(' enabled', ['id' => 'system-message-container']);
$this->see(' enabled', '#system-message-container');
}

/**
Expand Down Expand Up @@ -765,7 +765,7 @@ public function disablePlugin($pluginName)
$this->checkExistenceOf($pluginName);
$this->click(['xpath' => "//input[@id='cb0']"]);
$this->click(['xpath' => "//div[@id='toolbar-unpublish']/button"]);
$this->see(' disabled', ['id' => 'system-message-container']);
$this->see(' disabled', '#system-message-container');
}

/**
Expand All @@ -787,7 +787,7 @@ public function uninstallExtension($extensionName)
$this->click(['xpath' => "//div[@id='toolbar-delete']/button"]);
$this->acceptPopup();
$this->waitForText('was successful', '30', ['id' => 'system-message-container']);
$this->see('was successful', ['id' => 'system-message-container']);
$this->see('was successful', '#system-message-container');
$this->searchForItem($extensionName);
$this->waitForText(
'There are no extensions installed matching your query.',
Expand Down Expand Up @@ -836,7 +836,7 @@ public function checkExistenceOf($name)
{
$this->debug("Verifying if $name exist in search result");
$this->seeElement(['xpath' => "//form[@id='adminForm']/div/table/tbody"]);
$this->see($name, ['xpath' => "//form[@id='adminForm']/div/table/tbody"]);
$this->see($name, "//form[@id='adminForm']/div/table/tbody");
}

/**
Expand Down Expand Up @@ -872,7 +872,7 @@ public function installLanguage($languageName)
$this->click(['id' => "cb0"]);
$this->click(['xpath' => "//div[@id='toolbar-upload']/button"]);
$this->waitForText('was successful.', TIMEOUT, ['id' => 'system-message-container']);
$this->see('No Matching Results', ['class' => 'alert-no-items']);
$this->see('No Matching Results', '.alert-no-items');
$this->debug($languageName . ' successfully installed');
}

Expand Down Expand Up @@ -1193,7 +1193,7 @@ public function createCategory($title, $extension = '')

$this->debug('see a success message after saving the category');

$this->see('Category saved', ['id' => 'system-message-container']);
$this->see('Category saved', '#system-message-container');
$this->checkForPhpNoticesOrWarnings();
}
}