-
-
Notifications
You must be signed in to change notification settings - Fork 35
Added back codestyle checks via Drone #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jatitoam Any reason for Travis over our Drone? :-) |
|
Just used to it. Is Drone a preference now? |
|
@jatitoam as we got rid of travis totally in joomla 4 yes.. (We had and still have too many services) |
|
True and good idea to merge them. Can you please help me enable Drone for this repo so I can send a config file for it instead? |
|
@jatitoam okay done. Thanks! |
|
Ok it's switched @yvesh :) Can you please check and confirm? (and merge if you agree of course) Also remember to require the Drone check for develop and master pushes once it's enabled |
|
Heya :) just a friendly reminder, is it realistic to say that Drone will be enabled (and my code merged) if I solve conflicts? |
|
I activated drone for this repo, so if you solve the conflicts it should work |
# Conflicts: # src/JoomlaBrowser.php
|
Ok thanks, it's ready for merge now |
puneet0191
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jatitoam
|
@rdeutz can we merge this? |
|
Thank you @jatitoam |
|
:) np |
Important note: better squash this PR while merging, there was a good deal of tests while dealing with it
Enjoy !