Skip to content

Conversation

@jatitoam
Copy link
Contributor

@jatitoam jatitoam commented Jun 2, 2018

  • It uses latest joomla/coding-standards for checking
  • Added checks via Drone
  • Fixed Codeception to v.2.3.7 as it's the latest supported (cc @puneet0191)

Important note: better squash this PR while merging, there was a good deal of tests while dealing with it

Enjoy !

@jatitoam jatitoam requested review from puneet0191, rdeutz and yvesh June 2, 2018 19:25
@jatitoam jatitoam removed the request for review from yvesh June 2, 2018 19:39
@yvesh
Copy link
Contributor

yvesh commented Jun 3, 2018

@jatitoam Any reason for Travis over our Drone? :-)

@jatitoam
Copy link
Contributor Author

jatitoam commented Jun 3, 2018

Just used to it. Is Drone a preference now?

@yvesh
Copy link
Contributor

yvesh commented Jun 4, 2018

@jatitoam as we got rid of travis totally in joomla 4 yes.. (We had and still have too many services)

@jatitoam
Copy link
Contributor Author

jatitoam commented Jun 5, 2018

True and good idea to merge them. Can you please help me enable Drone for this repo so I can send a config file for it instead?

@yvesh
Copy link
Contributor

yvesh commented Jun 6, 2018

@jatitoam okay done. Thanks!

@jatitoam jatitoam changed the title Added back codestyle checks via Travis Added back codestyle checks via Drone Jun 9, 2018
@jatitoam
Copy link
Contributor Author

jatitoam commented Jun 9, 2018

Ok it's switched @yvesh :)
However I'm not sure what the Drone URL is to see the output so I tested it in a personal Drone in the meantime.

Can you please check and confirm? (and merge if you agree of course)

Also remember to require the Drone check for develop and master pushes once it's enabled

@jatitoam jatitoam requested a review from yvesh June 9, 2018 21:54
@jatitoam
Copy link
Contributor Author

Heya :) just a friendly reminder, is it realistic to say that Drone will be enabled (and my code merged) if I solve conflicts?

@rdeutz
Copy link
Contributor

rdeutz commented Jun 29, 2018

I activated drone for this repo, so if you solve the conflicts it should work

@jatitoam
Copy link
Contributor Author

jatitoam commented Jul 1, 2018

Ok thanks, it's ready for merge now

Copy link
Member

@puneet0191 puneet0191 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jatitoam

@puneet0191
Copy link
Member

@rdeutz can we merge this?

@puneet0191 puneet0191 merged commit 266d81c into joomla-projects:develop Jul 11, 2018
@puneet0191
Copy link
Member

Thank you @jatitoam

@jatitoam
Copy link
Contributor Author

:) np

@jatitoam jatitoam deleted the codestyle branch July 12, 2018 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants