[imp] Added a locator getter #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puneet0191
suggested changes
Aug 7, 2018
src/JoomlaBrowser.php
Outdated
| * @return mixed|false | ||
| * @since 3.8.11 | ||
| */ | ||
| public function getLocatorPath($locator) |
Member
There was a problem hiding this comment.
could you please change this name to $path?, because $this->locator->$locator could be very confusing to the fresh eye.
Contributor
Author
There was a problem hiding this comment.
ok there you go ;)
puneet0191
approved these changes
Sep 10, 2018
Member
|
Thanks @jatitoam |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a function to get locators from outside the JoomlaBrowser