Adding function to install a particular language. #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/JoomlaBrowser.php
Outdated
Member
There was a problem hiding this comment.
I think this xpath can be modified and made more readable, Is it not possible?
Member
There was a problem hiding this comment.
by the way
//* is not the correct way, it will make Codeception search through all the elements, and make the tests slower
//div, //form //p the element has to be inside some of them
Member
|
Thanks for PR! 👍 @vistiyos |
src/JoomlaBrowser.php
Outdated
Contributor
There was a problem hiding this comment.
not important but more performant: $I->click(['id' => "cb0"]);
Contributor
|
Thanks for the improvement @vistiyos ^_^ |
Contributor
|
I have merged at 359e48f resolving the recent conflicts. @puneet0191 leaving it to you for improving the paths in future pulls |
Member
|
yeap thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function receives the language name ( how appears in the language list) and it installs the language if exists. This function also refresh the language list to ensure that the language is there.