Improved notices and stricts to support more PHP debug modes and inexisting pages #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
it would not work in my local:
|
Contributor
Author
|
That's odd... I did not remove any line but I just added new options https://github.com/joomla-projects/joomla-browser/pull/46/files#diff-676cca4b1f4fdd04825e9c7ae7b54691R326 |
Member
|
What is the use case for this?, since we are already checking for 'Notice' keyword in page source |
Contributor
Author
|
Not all PHP debuggers show the same... mine for example uses <b>Notice</b>: so the assert does not match |
Contributor
|
ah! sorry I didn't notice that it was an addition. It has a lot of sense like this. Thanks |
javigomez
added a commit
that referenced
this pull request
Aug 5, 2015
Improved notices and stricts to support more PHP debug modes and inexisting pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.