Skip to content

#45 Wait for element change in Multilingual install too #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2015
Merged

#45 Wait for element change in Multilingual install too #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/JoomlaBrowser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,16 +160,14 @@ public function installJoomlaRemovingInstallationFolder()
$I->click(['xpath' => "//input[@value='Remove installation folder']"]);
$I->debug('I wait for Removing Installation Folder button to become disabled');
// @todo https://github.com/joomla-projects/joomla-browser/issues/45
$I->wait(2);
/*
$I->waitForElementChange(
['xpath' => "//input[@name='instDefault']"],
function(WebDriverElement $el) {
return !$el->isEnabled();
},
60
);
*/

$I->debug('Joomla is now installed');
$I->see('Congratulations! Joomla! is now installed.',['xpath' => '//h3']);
}
Expand Down Expand Up @@ -213,7 +211,13 @@ public function installJoomlaMultilingualSite($languages = array())
$I->waitForText('Congratulations! Joomla! is now installed.', 60, ['xpath' => '//h3']);
$this->debug('Removing Installation Folder');
$I->click(['xpath' => "//input[@value='Remove installation folder']"]);
$I->waitForElementVisible(['xpath' => "//input[@value='Installation folder successfully removed']"],60);
$I->waitForElementChange(
['xpath' => "//input[@name='instDefault']"],
function(WebDriverElement $el) {
return !$el->isEnabled();
},
60
);
$this->debug('Joomla is now installed');
$I->see('Congratulations! Joomla! is now installed.',['xpath' => '//h3']);
}
Expand Down