Force language change during installation #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianv
force-pushed
the
install-lang
branch
from
ce98663 to
7c0d242
Compare
florianv
force-pushed
the
install-lang
branch
from
7c0d242 to
4dd3075
Compare
florianv
changed the title
Contributor
|
Tested. Works Thanks @florianv 👍 |
javigomez
added a commit
that referenced
this pull request
Sep 22, 2015
Force language change during installation
javigomez
added a commit
to javigomez/webservices
that referenced
this pull request
Sep 24, 2015
Fixes the install Joomla function in browsers that are not en-GB by default. See joomla-projects/joomla-browser#59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When English is already selected, sometimes the installation page text still appears in the browser's language instead of the one selected. The installation will fail because the "Next" selector will not be found.
This PR fixes it by first selecting a random language to force refreshing of the lang strings when English is selected