-
Couldn't load subscription status.
- Fork 95
Technical Requirements – Added parse_ini_string #546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* As named as one requirement in Pre-Update Check improvements PR [46324](joomla/joomla-cms#46324) and linked to this place extended one line for 6.x with `parse_ini_string`. * As checked it is already included in 4.4.14 `administrator/components/com_joomlaupdate/src/Model/UpdateModel.php`, also added for 5.x. * Trailing spaces removed.
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
||||||||||||||||||
|
@richard67 could you please check and merge? |
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
👎 The additional requirement should be as short as the other requirements. |
|
Setting to DRAFT as formatting is lost, will improve |
- and added `parse_ini_string` requirement also for 5.4 (Legacy)
|
Sorry, that doesn't make sense to add single configuration options here, if you really like to add all needed php option here then you need to create a new page which handles "how to configure a webserver" or similar. We have many options that need to be right so that joomla works. |
|
ah, the trailing spaces are for line breaks, now replaced by HTML line break and added |
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
||||||||||||||||||
PR Code Suggestions ✨No code suggestions found for the PR. |
|
I have no idea why it's checked because if this function is disabled, it's only relevant if parse_ini_file is disabled. So actually joomla doesn't need |
@HLeithner That is not right. The code of the pre update checker also checks if the |
|
P.S.: Anyway, as long as we have that check with the link to the requirements in the pre-update checker, this PR here makes sense to me, and if it should be removed from the pre-update check, the documentation can be adjusted with a corresponding PR linked to the CMS PR which removes it. |
|
@muhme When checking the preview in the CI checks, I can see your change on the 5.4 and the 6.1 page, but not on the 6.0 page. I think you have to add it also to here: |
@richard67 Thank you for checking, I have added for 6.0 (Current) too |
|
Hmm, maybe the pre-update check should be adjusted so it does not check the |
|
it doesn't need to check it at all, if it is not there it will break as you see in the red screenshot. if it falls back to parse_ini_string it doesn't matter, so why scare people. |
|
Thank you @HLeithner and @richard67 for your investigations. Created joomla/joomla-cms#46359 |





User description
parse_ini_string.administrator/components/com_joomlaupdate/src/Model/UpdateModel.php, also added for 5.x.PR Type
Documentation
Description
Added
parse_ini_stringrequirement to technical documentationReplaced trailing spaces with HTML line breaks for consistency
Updated Joomla 6.x, 5.x, and 5.4 (Legacy) documentation
Added new "Required PHP Configuration" section
Diagram Walkthrough
File Walkthrough
technical-requirements.md
Add parse_ini_string requirement and fix formattingdocs/get-started/technical-requirements.md
parse_ini_stringrequirement for Joomla 6.x and 5.x
) for properformatting
technical-requirements.md
Add parse_ini_string requirement to 5.4 legacy docsversioned_docs/version-5.4/get-started/technical-requirements.md
parse_ini_stringrequirement for Joomla 5.4 (Legacy)
) for properformatting