Skip to content

Conversation

@elkuku
Copy link
Contributor

@elkuku elkuku commented Sep 6, 2014

This will fetch the commits for a PR and display them with the activity stream - as seen on GitHub.

This also tries to make our display more "GitHub like" and uses an octicon from #478

Example:
debug-3890

@brianteeman
Copy link
Contributor

Looks good

This comment was created with the J!Tracker Application at http://issues.joomla.org/.

@b2z
Copy link
Member

b2z commented Sep 8, 2014

Testing. Have an error:

0 Exception
DateTimeZone::__construct(): Unknown or bad timezone (Z)

In: /vagrant/src/App/Tracker/Model/IssueModel.php@107
File    Line    Class->Method()
IssueModel.php  107 DateTimeZone->__construct()
Item.php    70  App\Tracker\Model\IssueModel->getItem()
Application.php 177 App\Tracker\Controller\Issue\Item->initialize()
AbstractWebApplication.php  121 JTracker\Application->doExecute()
index.php   35  Joomla\Application\AbstractWebApplication->execute()

@elkuku
Copy link
Contributor Author

elkuku commented Sep 8, 2014

Seems that those things change with every PHP version :(

Please re-test.

@b2z
Copy link
Member

b2z commented Sep 8, 2014

Working :) I would move this styles <div class="span11" style="border: 1px solid silver; margin: 10px 0 10px;"> to the .css files and add border-radius: 3px;

aka "Here comes the UI guy" :P
@elkuku
Copy link
Contributor Author

elkuku commented Sep 8, 2014

OK - I'm not the UI guy 👅

b2z added a commit that referenced this pull request Sep 8, 2014
Add fetch PR commits and display them in the activity stream
@b2z b2z merged commit 79821f2 into joomla:master Sep 8, 2014
@elkuku elkuku deleted the pr-commits branch September 8, 2014 19:25
@b2z
Copy link
Member

b2z commented Sep 8, 2014

@mbabker note -> changes in DB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants