Skip to content

[5.0] Fix return type for onContentBeforeDisplay #41616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2023
Merged

[5.0] Fix return type for onContentBeforeDisplay #41616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/content/pagenavigation/src/Extension/PageNavigation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ final class PageNavigation extends CMSPlugin
* @param mixed &$params The article params
* @param integer $page The 'page' number
*
* @return mixed void or true
* @return void
*
* @since 1.6
*/
Expand All @@ -50,7 +50,7 @@ public function onContentBeforeDisplay($context, &$row, &$params, $page = 0)
$print = $app->getInput()->getBool('print');

if ($print) {
return false;
return;
}

if ($context === 'com_content.article' && $view === 'article' && $params->get('show_item_navigation')) {
Expand Down
4 changes: 2 additions & 2 deletions plugins/content/vote/src/Extension/Vote.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ public function onContentAfterDisplay($context, &$row, &$params, $page = 0)
* @param object &$params The article params
* @param integer $page The 'page' number
*
* @return string|boolean HTML string containing code for the votes if in com_content else boolean false
* @return string HTML string containing code for the votes if in com_content else empty string
*
* @since 3.7.0
*/
Expand All @@ -93,7 +93,7 @@ private function displayVotingData($context, &$row, &$params, $page)
$parts = explode('.', $context);

if ($parts[0] !== 'com_content') {
return false;
return '';
}

if (empty($params) || !$params->get('show_vote', null)) {
Expand Down