Skip to content

fix #10: Prevent showing "Reference not found" when refusing to select any reference#11

Merged
laurent22 merged 1 commit intomainfrom
fix-reference-not-found
Jun 28, 2021
Merged

fix #10: Prevent showing "Reference not found" when refusing to select any reference#11
laurent22 merged 1 commit intomainfrom
fix-reference-not-found

Conversation

@xUser5000
Copy link
Copy Markdown
Contributor

This is a fix to issue #10

What has been done

  • Make showCitationPopup() return an empty string when there is no selected reference (previously it was returning undefined when encountering such situation).
  • Check if (referenceId === "") return; in add-bibtex-reference.command.ts

@laurent22
Copy link
Copy Markdown
Member

Ok that makes sense.

@laurent22 laurent22 merged commit b542b80 into main Jun 28, 2021
@xUser5000 xUser5000 mentioned this pull request Jul 3, 2021
xUser5000 added a commit that referenced this pull request Jul 3, 2021
## New features
- #12
- #8

## Bug fixes
- #7
- #9
- #11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Reference not found" error message when refusing to select any reference

2 participants