Conversation
Member
|
Actually let me know when it's finished as I think it's easier that way. Otherwise my comments will be obsolete by the time you finish, or I might suggest changes that you're already planning to do. |
Contributor
Author
|
Did the following:
|
laurent22
reviewed
Jul 31, 2021
| type: SettingItemType.String, | ||
| section: SETTINGS_SECTION_ID, | ||
| public: true, | ||
| label: "BibTeX File", |
Member
There was a problem hiding this comment.
In the description, you should mention that multiple files can be specified, separated by ;
| joplin.settings.onChange(async (event) => { | ||
| if (event.keys.includes(SETTINGS_CSL_FILE_PATH_ID)) { | ||
| await setProcessorStyle(processor); | ||
| await joplin.views.dialogs.showMessageBox(MESSAGE_RESTART_APP); |
Member
There was a problem hiding this comment.
Does that work even from the config screen? Actually, you could simply add a description below the field to say that the app needs to be restarted.
Contributor
Author
|
Done |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The feature is not complete yet, but I decided to PR the changes I've done till now and get a review while working on the rest of the implementation. This saves a lot of time in my opinion. Please, don't merge this PR until I finish the initial implementation.
What has been done (till now)
CSLProcessorSingleton Class.cslfile for styling. By default (if the field is empty), the APA style is used.Screenshots
APA
IEEE
What's next
.cslfile (like "file not found" or "invalid format")