Add differentiated graphs for dark and light mode#20
Merged
jorgef merged 3 commits intojorgef:masterfrom Jul 31, 2022
Merged
Conversation
Owner
|
Thanks!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As an initial improvement to accessibility in dark mode, all charts were given a white background to improve contrast. However github also offers the use of
(prefers-color-scheme: dark)and(prefers-color-scheme: light)to have differentiated graphs for the different themes.This PR introduces dedicated dark-mode versions of the radar graphs, and updates the md files to reference the right version based on the user's browser.