-
Notifications
You must be signed in to change notification settings - Fork 71
setup workspace with devcontainer #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setup workspace with devcontainer #5
Conversation
|
Wow thank you for the great work @luutuankiet I am wondering if it would be possible to add any tests for this? |
|
@josephmachado good catch, I don't have much experience writing these kinds of test for container but I'll give it a shot! For now I am leaning to a workflow that builds a container from the devcontainer.json instructions, then run the primary make commands from the course for example For now you can test it yourself by opening the commit in a codespace. It actually helped me debug a network related issue when I tried to setup the lab. |
Ah I should clarify here @luutuankiet If you can record a video or add instructions on how to use this, me and others can benefit from it. With the instructions I'll try to recreate it (locally and on codespaces) and if that works, we should be good to go. |
|
@josephmachado gotcha, please find the instructions below:
Alternatively, head over to my branch and hit
(other files such as env_init.sh, source_env.sh are also required to be kept as is for the scripts to source and invoked correctly. Also, run the vs code command "Reload window" if after finished building the containers vs code shows any extensions errors.)
A closing note, I find this setup beneficial for someone who likes to get their hands dirty by exploring the source code and understand how to rebuild them altogether. The Make commands are intuitive as it is but not without its own limitation as they're wrapped by docker exec/run commands which abstracts away the code flow. |
|
This is great, TY |
josephmachado
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM




added devcontainer config & setup scripts to spin a host devcontainer matching the master spark's environment in
efficient_data_processing_spark/data-processing-spark/1-lab-setup/containers/spark.The devcontainer will be able to perform imports and run arbitrary code for further exploration if needed :