Trace all HTTP codes other than 200 as errors #575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Looks good but you forgot to check format! |
josh-proxy/src/bin/josh-proxy.rs
Outdated
| let _e = s.enter(); | ||
| let http_status = r.status().as_u16() | ||
| let log_level = match http_status { | ||
| 200 => tracing::Level::TRACE, |
Member
There was a problem hiding this comment.
I would prefer something like:
< 400 -> TRACE // All different kinds of success
< 500 -> WARN // Something wrong with the request, clients fault
_ -> ERROR // Server side error, need to debug josh
Member
There was a problem hiding this comment.
Actually, the first should probably be <= 401, as "unauthorized" is a very common and normal response that will happen pretty much all the time without any need for concern.
Collaborator
Author
There was a problem hiding this comment.
@christian-schilling but it also returns 500 here when checkout URL is malformed
Collaborator
Author
There was a problem hiding this comment.
ah I think it still makes sense. Thanks, I'll update the PR a bit later
Member
There was a problem hiding this comment.
If it returns 500 when the URL is malformed that's a bug in itself, it should be something 4xx.
vlad-ivanov-name
force-pushed
the
report-http-errors
branch
from
817092e to
05d2a56
Compare
This allows to raise logging level but still see 500, 404 errors etc
vlad-ivanov-name
force-pushed
the
report-http-errors
branch
from
05d2a56 to
29545b0
Compare
christian-schilling
approved these changes
Dec 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to raise logging level but still see 500, 404 errors etc