Add more optimiser rules for subtract #612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-schilling
force-pushed
the
subtract-opt
branch
from
51005df to
b6587ba
Compare
christian-schilling
changed the title
LMG
approved these changes
Feb 4, 2022
Collaborator
LMG
left a comment
LMG
left a comment
There was a problem hiding this comment.
You need to update the test and I have a few questions but otherwise looks good to me
| } | ||
| } | ||
|
|
||
| fn prefix_of(op: Op) -> Filter { |
Collaborator
There was a problem hiding this comment.
I'm not sure about the name here... This gets the last of a chain, if it is a prefix?
| Op::Chain(a, to_filter(Op::Subtract(b, d))) | ||
| } | ||
| (_, b) if prefix_of(b.clone()) != to_filter(Op::Nop) => { | ||
| Op::Subtract(af, last_chain(to_filter(Op::Nop), to_filter(b.clone())).0) |
Collaborator
There was a problem hiding this comment.
here you are redoing the same operation as in prefix_of. Might be optimizable?
Changing just the prefix part of a mapping in very large workspaces resulted in very expensive filtering that can be avoided by applying these additional rules.
christian-schilling
force-pushed
the
subtract-opt
branch
from
b6587ba to
66e484f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing just the prefix part of a mapping in very large
workspaces resulted in very expensive filtering that can be
avoided by applying these additional rules.