Skip to content

Conversation

@josh-wong
Copy link
Owner

Description

This PR:

  • Clarifies the wording in the cookie consent banner.
  • Fixes an issue where the hyperlinked text to the cookie policy in the cookie consent banner is impossible to see when the site is using the light theme.

Related issues and/or PRs

Changes made

  • Revised the text in the cookie consent banner for clarity.
  • Hard-coded a style for the cookie consent banner to make the hyperlinked text appear when the site is using the light theme.

Checklist

The following is a best-effort checklist. If any items in this checklist aren't applicable to this PR, add N/A after each item.

Documentation

  • I have updated the side navigation as necessary. N/A
  • I have updated the documentation to reflect the changes. N/A
  • I have documented or updated any remaining open issues linked to this PR in GitHub, Obsidian, etc. N/A

Build, deploy, and test

  • I have merged and published any dependent changes in other PRs. N/A
  • I have commented my code, particularly in hard-to-understand areas. N/A
  • I have checked that my changes look as expected on a locally built version of the docs site.
  • My changes generate no new warnings.

When the site is using the light theme, the link to the cookie policy is the same as the background of the cookie consent banner, which makes the text for the link impossible to see.
@josh-wong josh-wong added bugfix Bug is fixed improvement Improvement to an existing feature labels Dec 13, 2024
@josh-wong josh-wong self-assigned this Dec 13, 2024
@github-actions
Copy link
Contributor

All items in the checklist have been checked🎉

@josh-wong josh-wong merged commit 50c7925 into main Dec 13, 2024
1 check passed
@josh-wong josh-wong deleted the revise-cookie-consent-banner-text branch December 13, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Bug is fixed improvement Improvement to an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants