Skip to content

Conversation

@josh
Copy link
Owner

@josh josh commented Nov 13, 2025

Summary

  • remove the Java (OpenJDK) and Julia packages from Mason extra packages to avoid pulling Java runtimes
  • ignore Mason health warnings for missing Java, Javac, and Julia binaries since they are intentionally absent

Testing

  • nix flake check --accept-flake-config --show-trace --print-build-logs --keep-going

Codex Task

Copilot AI review requested due to automatic review settings November 13, 2025 17:46
Copilot finished reviewing on behalf of josh November 13, 2025 17:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes Java (OpenJDK) and Julia runtime dependencies from Mason to avoid pulling unnecessary heavy runtimes into the Neovim environment.

  • Removed jdk and julia from the Nix package imports and Mason's extraPackages
  • Replaced conditional Julia warning ignoring with static warning suppressions for java, javac, and julia binaries
  • Cleaned up unused imports (lib, stdenv, julia) from test and LazyVim configuration files

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
plugins.nix Removed jdk and julia from imports and Mason's extraPackages list, eliminating conditional Julia platform availability logic
pkgs/tests/mason-nvim-checkhealth.nix Removed unused imports and converted ignoreLines to static list of warnings for intentionally missing java, javac, and julia binaries
pkgs/LazyVim.nix Removed unused imports and updated Mason checkhealth test to ignore warnings for intentionally absent java, javac, and julia binaries

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@josh josh merged commit 870e19f into main Nov 13, 2025
10 checks passed
@josh josh deleted the codex/disable-java-and-openjdk-dependencies branch November 13, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants