Restore Mason Java and Julia dependencies #1410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR restores Mason's Java (JDK) and Julia dependencies that were previously removed in PR #1406. The changes add these language runtimes back to Mason's extraPackages and update test configurations accordingly.
- Adds
jdkandjuliato Mason's build dependencies inplugins.nix - Removes Java-related warning ignores from test configurations (since JDK is now provided)
- Implements conditional Julia inclusion based on platform availability using
lib.meta.availableOn
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| plugins.nix | Adds jdk to function parameters and Mason's extraPackages list; adds julia conditionally based on platform availability |
| pkgs/tests/mason-nvim-checkhealth.nix | Adds required parameters (lib, stdenv, julia) and conditionally ignores Julia warning based on platform support |
| pkgs/LazyVim.nix | Adds required parameters (stdenv, julia) and conditionally ignores Julia warning in Mason health check based on platform support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
josh
force-pushed
the
revert-1406-codex/disable-java-and-openjdk-dependencies
branch
from
48755be to
16c3cc4
Compare
josh
deleted the
revert-1406-codex/disable-java-and-openjdk-dependencies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1406