Skip to content

Conversation

@matheusaraujo
Copy link
Contributor

Hey guys, first of all, really nice job here! 👏 I'm using and loving it! 🚀

There's only one little thing that, in my opinion, could be improved: include the problem title on the commit message, it would make easier to find the problem on git history.

I've made this simple change to achieve it.

But since this is a very personal preference, I believe a more generic solution would be better.

My idea is having an input variable commit-message-template replacing the existing commit-header.
On this variable the pre-defined available infos could be defined using a template string, the default value could be exact like [LeetCode Sync] - Runtime - ${submission.runtime} (${submission.runtimePerc}), Memory - ${submission.memory} (${submission.memoryPerc}), keeping the current behavior, but also improving the flexibility.

I haven't implemented yet just because of time, the current forked works well for me. But, if you guys also believes that this is a good idea, I can try to implement it!

@joshcai joshcai merged commit 6f1bc27 into joshcai:master Aug 30, 2024
@joshcai
Copy link
Owner

joshcai commented Aug 30, 2024

Thanks for the contribution @matheusaraujo! Apologies in the delay in reviewing, but I think this looks great for now. If other users decide they want more flexibility in the commit message, that could be an additional feature added later - will go ahead and merge this.

@matheusaraujo
Copy link
Contributor Author

Great, @joshcai! Thanks for the update!
Do you already know when a new release will be created?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants