Skip to content

Comment out Prometheus scrape targets for missing services#26

Merged
joshdev8 merged 1 commit into
mainfrom
fix/prometheus-scrape-targets
Apr 1, 2026
Merged

Comment out Prometheus scrape targets for missing services#26
joshdev8 merged 1 commit into
mainfrom
fix/prometheus-scrape-targets

Conversation

@joshdev8
Copy link
Copy Markdown
Owner

@joshdev8 joshdev8 commented Apr 1, 2026

Summary

  • Comment out Prometheus scrape jobs for services not defined in docker-compose.yml: cadvisor, node-exporter, netdata, plex-exporter
  • Keep active scrape jobs for prometheus (self), telegraf, and tautulli
  • Each commented block has an "Uncomment after adding X to docker-compose.yml" note

These phantom targets would generate constant scrape errors in the Prometheus logs.

Test plan

  • Verify docker compose up -d prometheus starts without scrape errors
  • Verify Telegraf and Tautulli metrics are still scraped

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Disabled monitoring scrape jobs for cAdvisor, node-exporter, netdata, and plex-exporter in the monitoring configuration. These services are no longer scraped for metrics, while their configuration templates remain available for future use.

Scrape jobs for cadvisor, node-exporter, netdata, and plex-exporter
are commented out since these services are not in docker-compose.yml.
Each has a note to uncomment after adding the service.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 1, 2026

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 695e52d7-e8e1-4545-a4d6-a1c0bc320729

📥 Commits

Reviewing files that changed from the base of the PR and between a71ecb3 and d5be875.

📒 Files selected for processing (1)
  • prometheus/prometheus.yml

📝 Walkthrough

Walkthrough

The prometheus/prometheus.yml configuration file was updated to disable four external scrape jobs (cAdvisor/docker, node-exporter, netdata, and plex-exporter) by converting their active configurations into commented "Uncomment after…" template sections. These scrape targets are no longer active in the Prometheus runtime.

Changes

Cohort / File(s) Summary
Prometheus Scrape Configuration
prometheus/prometheus.yml
Disabled four external scrape jobs (cAdvisor, node-exporter, netdata, plex-exporter) by commenting out their configurations and adding "Uncomment after…" template headers while preserving their original settings.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Four scrapers sleep in comments deep,
Their metrics now in silence keep,
With "Uncomment" notes for future days,
Prometheus takes a restful gaze! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: commenting out Prometheus scrape targets for services that are not currently defined in the docker-compose configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/prometheus-scrape-targets

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@joshdev8 joshdev8 merged commit b7c9a30 into main Apr 1, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant