Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #31 +/- ##
=======================================
Coverage 98.62% 98.63%
=======================================
Files 98 98
Lines 2479 2497 +18
=======================================
+ Hits 2445 2463 +18
Misses 34 34
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
jon-sully
reviewed
Apr 22, 2023
Comment on lines
+174
to
+197
| context 'multiple subscriptions' do | ||
| it 'creates a new active subscription' do | ||
| user = create(:user) | ||
| sub = campaign.subscribe!(user) | ||
| sub.end! | ||
| sub2 = campaign.subscribe!(user) | ||
| expect(sub2).to_not eq(sub) | ||
| end | ||
|
|
||
| it 'returns an existing subscription if it is only unsubscribed' do | ||
| user = create(:user) | ||
| sub = campaign.subscribe!(user) | ||
| sub.unsubscribe! | ||
| sub2 = campaign.subscribe!(user) | ||
| expect(sub2).to eq(sub) | ||
| end | ||
|
|
||
| it 'returns the existing if there is an active sub' do | ||
| user = create(:user) | ||
| sub = campaign.subscribe!(user) | ||
| sub2 = campaign.subscribe!(user) | ||
| expect(sub2).to eq(sub) | ||
| end | ||
| end |
Collaborator
There was a problem hiding this comment.
Nice, these are great behavior specs! 👍
Co-authored-by: Jon Sullivan <hey@jonsully.net>
Collaborator
|
🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Campaign#subscribeshould onlyfind_or_createfor subscriptions that haven't ended.