Campaign Subscription :on_complete after destruction

[jon-sully]

Submitting this little behavior change just to clarify that the on_complete callback shouldn't run during the destruction of a campaign_subscription (even if that's rare!). I think this happens because :completed? is technically true during destruction — the number of unsent mailings is indeed zero, because they're all deleted first 😛

[codecov]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a7144c6) 98.63% compared to head (aa446eb) 98.64%.

❗ Current head aa446eb differs from pull request most recent head 5c2439a. Consider uploading reports for the commit 5c2439a to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##           master      #33   +/-   ##
=======================================
  Coverage   98.63%   98.64%           
=======================================
  Files          98       98           
  Lines        2497     2502    +5     
=======================================
+ Hits         2463     2468    +5     
  Misses         34       34           

Impacted Files	Coverage Δ
app/models/caffeinate/campaign_subscription.rb	100.00% <100.00%> (ø)
...ec/models/caffeinate/campaign_subscription_spec.rb	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[jon-sully]

❤️

[jon-sully]

Oh I tried to leave that ❤️ specifically on the diff for the spec add (thank you!) but I guess Github just left it as a general comment. Github's trying to not constrain my love to only specific things. Love for all. ¯_(ツ)_/¯