fix: template-redis-enterprise feature gate and example API updates#204
Merged
joshrotenberg merged 1 commit intomainfrom Jan 5, 2026
Merged
fix: template-redis-enterprise feature gate and example API updates#204joshrotenberg merged 1 commit intomainfrom
joshrotenberg merged 1 commit intomainfrom
Conversation
- Add template-redis-enterprise to feature gate cfg in src/lib.rs and src/template.rs - Update testing_basics.rs to use current ExecCommand and LogsCommand API signatures - Add dynamic port mapping and readiness probe for Postgres in test_fixtures.rs - Add test_sentinel example entry to Cargo.toml Co-authored-by: David Horner <davehorner@users.noreply.github.com>
joshrotenberg
force-pushed
the
fix/dave-pr-200-fixes
branch
from
d72ce89 to
de5605c
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issues identified by @davehorner in PR #200.
Changes
template-redis-enterpriseto feature gate cfg attributes so the template module compiles when only that feature is enabledExecCommand::new(container, command_vec)(2 args, not 1)LogsCommandreturns struct with.stdoutfieldRunCommand::cmd()takesVec<String>port_dyn) and PostgreSQL readiness probe to avoid port collisions and race conditionstest_sentinelexample entryTesting
cargo build --examples --all-featurescargo test --example testing_basics --no-runCloses #200 (supersedes Dave's PR with formatting fixes applied)