fix: use serial_test for env var tests to prevent race conditions#213
Merged
joshrotenberg merged 1 commit intomainfrom Jan 5, 2026
Merged
fix: use serial_test for env var tests to prevent race conditions#213joshrotenberg merged 1 commit intomainfrom
joshrotenberg merged 1 commit intomainfrom
Conversation
joshrotenberg
force-pushed
the
fix/env-test-race-condition
branch
from
a51a21f to
6cdcc05
Compare
- Added serial_test dependency for tests that modify environment variables - Marked env var tests with #[serial] to prevent race conditions - Changed MySQL readiness check to use TCP (127.0.0.1) instead of Unix socket - Require 2 consecutive successful connections before declaring ready - Updated test to also use TCP connection for consistency
joshrotenberg
force-pushed
the
fix/env-test-race-condition
branch
from
6cdcc05 to
eeedc43
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two flaky test issues:
1. Environment variable test race condition
test_redis_cluster_from_env_with_varswas failing because environment variable tests were racing against each other when running in parallel.Fix: Added
serial_testas a dev dependency and marked both env var tests with#[serial].2. MySQL readiness check too early
test_mysql_basic_start_stopwas failing with:The
mysqladmin pingcheck can succeed before the socket is fully ready for client connections.Fix: Changed the readiness check to use
mysql -e 'SELECT 1'which is the same operation the tests perform, ensuring the socket is fully ready.