feat: add wait_for_ready() method and builder option to ContainerGuard#225
Merged
joshrotenberg merged 1 commit intomainfrom Jan 5, 2026
Merged
feat: add wait_for_ready() method and builder option to ContainerGuard#225joshrotenberg merged 1 commit intomainfrom
joshrotenberg merged 1 commit intomainfrom
Conversation
- Add wait_for_ready() convenience method on ContainerGuard that delegates to the underlying template's readiness check - Add wait_for_ready builder option to automatically wait during start() - Works for both new and reused containers Closes #218
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #218. Adds convenience method and builder option to
ContainerGuard.Changes
New Methods
wait_for_ready()on ContainerGuard:New Builder Option
wait_for_ready(bool)builder method:Behavior
start()block until the container passes its readiness checkreuse_if_runningis enabled)wait_for_ready()implementationTesting
Closes #218