fix: compose commands producing "docker docker compose" (#233)#234
Merged
joshrotenberg merged 3 commits intomainfrom Jan 16, 2026
Merged
fix: compose commands producing "docker docker compose" (#233)#234joshrotenberg merged 3 commits intomainfrom
joshrotenberg merged 3 commits intomainfrom
Conversation
The execute_command helper was passing "docker" as the command name for compose commands, but CommandExecutor also prepends the command name to args before running. This resulted in "docker docker compose ..." instead of "docker compose ...". Fix: Pass "compose" as the command name and skip the redundant "compose" prefix from args. Changes: - Fix execute_command to pass "compose" as command name for compose commands - Add regression tests in ps.rs and command.rs - Expand CI antipattern check to include src/command.rs Fixes #233 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
In
src/command.rs, theexecute_commandhelper was passing"docker"as the command name for compose commands:But
CommandExecutor::execute_commandinserts the command name at position 0 of the args, then runs the command usingdockeras the runtime binary. This resulted in:Fix
Pass
"compose"as the command name and skip the redundant "compose" prefix from args:Changes
test_compose_args_no_docker_prefixregression testtest_compose_command_args_structureregression testsrc/command.rsTest plan
Fixes #233