uv_getaddrinfo_cb status code documentation incorrect

[vtjnash]

The status argument for uv_getaddrinfo_cb is stated to be 0 on success and -1 on error. In fact, the unix code for this function returns the result returned by the getaddrinfo call (typically a small positive integer)
https://github.com/joyent/libuv/blob/master/include/uv.h#L1265

[txdv]

There are a lot of inconsistencies around because the win and unix part was mainly written by two separate people.
Having an issue will help focus on making it consistent.

[saghul]

What does that small integer mean? From OSX's man(3) page: "getaddrinfo() returns zero on success or one of the error codes listed in gai_strerror(3) if an error occurs."

[vtjnash]

on OS X, the gai_strerror return codes are small integers. that's all i meant:

/*
 * Error return codes from getaddrinfo()
 */
#if !defined(_POSIX_C_SOURCE) || defined(_DARWIN_C_SOURCE)
#define EAI_ADDRFAMILY   1  /* address family for hostname not supported */
#endif /* (!_POSIX_C_SOURCE || _DARWIN_C_SOURCE) */
#define EAI_AGAIN    2  /* temporary failure in name resolution */
#define EAI_BADFLAGS     3  /* invalid value for ai_flags */
#define EAI_FAIL     4  /* non-recoverable failure in name resolution */
#define EAI_FAMILY   5  /* ai_family not supported */
#define EAI_MEMORY   6  /* memory allocation failure */
#if !defined(_POSIX_C_SOURCE) || defined(_DARWIN_C_SOURCE)
#define EAI_NODATA   7  /* no address associated with hostname */
#endif /* (!_POSIX_C_SOURCE || _DARWIN_C_SOURCE) */
#define EAI_NONAME   8  /* hostname nor servname provided, or not known */
#define EAI_SERVICE  9  /* servname not supported for ai_socktype */
#define EAI_SOCKTYPE    10  /* ai_socktype not supported */
#define EAI_SYSTEM  11  /* system error returned in errno */
#if !defined(_POSIX_C_SOURCE) || defined(_DARWIN_C_SOURCE)
#define EAI_BADHINTS    12  /* invalid value for hints */
#define EAI_PROTOCOL    13  /* resolved protocol is unknown */
#endif /* (!_POSIX_C_SOURCE || _DARWIN_C_SOURCE) */
#define EAI_OVERFLOW    14  /* argument buffer overflow */
#if !defined(_POSIX_C_SOURCE) || defined(_DARWIN_C_SOURCE)
#define EAI_MAX     15
#endif /* (!_POSIX_C_SOURCE || _DARWIN_C_SOURCE) */

(from /usr/include/netdb.h)

[saghul]

Ah, you meant in case of error :-)