Skip to content

Allow list-item tag name to be customised #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpadilla merged 1 commit into from
Jun 11, 2015
Merged

Allow list-item tag name to be customised #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions rest_framework_xml/renderers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ class XMLRenderer(BaseRenderer):
media_type = 'application/xml'
format = 'xml'
charset = 'utf-8'
item_tag_name = 'list-item'

def render(self, data, accepted_media_type=None, renderer_context=None):
"""
Expand All @@ -41,9 +42,9 @@ def render(self, data, accepted_media_type=None, renderer_context=None):
def _to_xml(self, xml, data):
if isinstance(data, (list, tuple)):
for item in data:
xml.startElement("list-item", {})
xml.startElement(self.item_tag_name, {})
self._to_xml(xml, item)
xml.endElement("list-item")
xml.endElement(self.item_tag_name)

elif isinstance(data, dict):
for key, value in six.iteritems(data):
Expand Down
6 changes: 6 additions & 0 deletions tests/test_renderers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,12 @@ def test_render_complex_data(self):
self.assertXMLContains(content, '<sub_name>first</sub_name>')
self.assertXMLContains(content, '<sub_name>second</sub_name>')

def test_render_list(self):
renderer = XMLRenderer()
content = renderer.render(self._complex_data, 'application/xml')
self.assertXMLContains(content, '<sub_data_list><list-item>')
self.assertXMLContains(content, '</list-item></sub_data_list>')

@unittest.skipUnless(etree, 'defusedxml not installed')
def test_render_and_parse_complex_data(self):
"""
Expand Down