Confused with jwt.decode return type

[Hanaasagi]

I am using mypy to check my code. And I find that the annotation of jwt.decode's return value is Mapping[str, Any]. It's immutable, so if i change it, mypy will complain Unsupported target for indexed assignment. I think the type should be Dict[str, Any] or MutableMapping[str, Any]. Are there someone give a official solution?

More detail, please see python/typeshed#2764

[jpadilla]

@jacopofar see any objections here?

[jacopofar]

Seems a good idea, I tried to implement it and it passes the tests and mypy.

It took me some time to realize why it was Mapping, and apparently mypy inferred it from the check at line 100.

[Hanaasagi]

Thank you so much for the feedback. But I think that after calling json.loads, the key of dict must be a str type, maybe Dict[str, Any] is better. I've made some changes in python/typeshed#2765.

[jacopofar]

Right, fixed. Is it still needed?

[jpadilla]

@jacopofar yes please! 👍