.NET driver can't create records in multi-master replicated database #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for cluster 'v' (it is 'Node2')" when hosting a database on more than one server with multi-master replication. (JIRA SM-248)
jpamp
requested changes
Mar 9, 2017
Owner
jpamp
left a comment
jpamp
left a comment
There was a problem hiding this comment.
Just have the one comment. Can you address?
|
|
||
| if (_document.ORID == null) | ||
| { | ||
| var clusterId = _database.GetClusterIdFor(_document.OClassName); |
Owner
There was a problem hiding this comment.
Do we still need this line if we are not using the value anymore?
Collaborator
Author
There was a problem hiding this comment.
No, that is not needed. Thanks!
jpamp
approved these changes
Mar 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change solves the issue of "Local node 'Node1' is not the owner for cluster 'v' (it is 'Node2')" when hosting a database on more than one server with multi-master replication. (JIRA SM-248) This solution was identified by Colin Leister from OrientDB.