Add typed sum aggregation methods to NumberExpression#2
Merged
jparams merged 2 commits intoquerydsl-5.0.0from Mar 13, 2026
Merged
Conversation
…,-sumbiginteger-methods-4mv7xt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
sumresults map to appropriate numeric types (double, long, BigDecimal, BigInteger) rather than always using the expression's original type.NumberExpression.Description
BigDecimalandBigIntegerand a private generic helper methodsum(Class<P>)to create typed sum aggregation expressions.sum()to delegate to the genericsumhelper and added typed convenience methodssumDouble(),sumLong(),sumBigDecimal(), andsumBigInteger().@SuppressWarnings("unchecked")where appropriate to handle generic casting in the new helper andsum()implementation.NumberExpressionTestwith testssumBigDecimal_has_bigDecimal_type,sumBigInteger_has_bigInteger_type,sumDouble_has_double_type, andsumLong_has_long_typeto verify the resulting aggregation types.Testing
NumberExpressionTestwhich include the newly added type-assertion tests; all tests passed.mvn -Dtest=NumberExpressionTest test) and observed successful completion.Codex Task