Conversation
…ow into jp_20260325_samplerfix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The distributed sampler was causing issues on LUMI with 8 GPUs if different workers ran out of the dataset at different times. The tests are expected to fail, there is an outdated test on the main branch that is removed in this PR.
TODO:
pyg-cld-hits-v1_cld_20260326_093401_088146has trained on LUMI for 24h and post the loss curves to check that it doesn't crash nowThe learning rate might need tuning but it seems there are no more issues with the sampler. EDIT: found a crash on 2xL40s after 40k steps, fix attempt in be6b00a.
pyg-cld-hits-v1_cld_20260327_081645_454635has trained on LUMI after fixing be6b00a.pyg-cld-hits-v1_cld_20260327_081548_787211has trained on Tallinn, same as above