Fix incorrect progress reporting when resuming downloads#900
Merged
jpdillingham merged 12 commits intomasterfrom Mar 14, 2026
Merged
Fix incorrect progress reporting when resuming downloads#900jpdillingham merged 12 commits intomasterfrom
jpdillingham merged 12 commits intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #900 +/- ##
==========================================
+ Coverage 98.83% 98.86% +0.03%
==========================================
Files 184 184
Lines 6498 6508 +10
Branches 996 996
==========================================
+ Hits 6422 6434 +12
Misses 49 49
+ Partials 27 25 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



When transfer logic was refactored in #866, I made the mistake to add the start output to the stream position when reporting the final progress for the transfer. The stream position is enough; it should end up at precisely the size of the transferred file; there's no need to add the start offset. I've corrected this issue.
When making these changes I realized that the logic to update progress during the transfer (via the
DataReadevent) relies on the start offset, plus the number of bytes transferred so far. This doesn't agree with the final updates using the stream position, if the stream we are given isn't properly positioned at the start offset.I've added logic to automatically seek the given stream to the proper place when a start offset is supplied. This can be overridden with a transfer option
SeekOutputStreamAutomatically, but anyone setting this tofalseneeds to understand that the data provided in the final updates is likely going to be incorrect for them, and they need to compensate.