Throw if minorVersion is 100#910
Merged
jpdillingham merged 1 commit intojpdillingham:minorfrom Mar 29, 2026
Merged
Conversation
Owner
|
Thanks for catching this. I'm going to merge it into another branch and add some additional tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
100didn't throw but Exception message says "The minor version must be greater than 100"It makes sense to disallow minorVersion
100because legacy clients using library version 8.5.0 and below all had that value and the idea is that projects have different values from each other so they can be differentiated.