fix(atom): escape & in category attribute values#249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Atom renderer puts category values into attributes (
<category term="..."/>for feed-level categories, andlabel/scheme/termfor item categories) and hands them toxml-jsunescaped.xml-jsescapes&inside element text but not inside attribute values, so a category containing an ampersand produces non-well-formed XML:The RSS2 renderer already escapes the same value because it emits the category as element text, where
xml-jsdoes escape&. So the two formats disagree for identical input, and the Atom output is invalid.This applies the existing
sanitize()helper to the category attributes, the same approach used for enclosure URLs in #228. Feed-level snapshots are unchanged because the sample categories contain no&. Added a test covering the feed-leveltermand the item-levellabel/scheme.