Fix wrong expiration time parsing#120
Merged
jpochyla merged 2 commits intojpochyla:masterfrom Aug 20, 2021
Merged
Conversation
Owner
|
Hi @JuliDi, thanks for the fix! It seems like we're getting different URL formats. I've combined the parsing approaches in the latest commit here. Can you please verify it works on your side? |
Contributor
Author
|
Very odd... but your commit works on my end, as well: Looks ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parsing of the expiration time seems to be wrong (probably outdated?), giving me a
failed to parse expiration time from URL ...warning.Not sure whether these server responses can differ across operating systems or so. At least building from master on macOS 10.15 I get a response of the form
.../...a35817ca410?__token__=exp=1629466995~hmac=df348....With the changes in this PR, the issue seems fixed – the log says that a new token has been requested because it was outdated.