gui: Avoid search action if query is empty#209
Merged
jpochyla merged 1 commit intojpochyla:masterfrom Nov 11, 2021
guerinoni:search-fix-emtpy-query
Merged
gui: Avoid search action if query is empty#209jpochyla merged 1 commit intojpochyla:masterfrom guerinoni:search-fix-emtpy-query
jpochyla merged 1 commit intojpochyla:masterfrom
guerinoni:search-fix-emtpy-query
Conversation
This avoid to show api error from spotify. Signed-off-by: Federico Guerinoni <guerinoni.federico@gmail.com> Co-authored-by: Paolo Barbolini <paolo@paolo565.org>
Contributor
Author
|
@jpochyla any news? |
jpochyla
reviewed
Nov 9, 2021
| .with_placeholder("Search") | ||
| .controller(InputController::new().on_submit(|ctx, query, _| { | ||
| if query.trim().is_empty() { | ||
| return |
Contributor
Author
There was a problem hiding this comment.
As lambda it works, but if you prefer I can add it :)
Owner
|
Hi! Thanks for the change and sorry for the delay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoid to show api error from spotify.
Signed-off-by: Federico Guerinoni guerinoni.federico@gmail.com
Co-authored-by: Paolo Barbolini paolo@paolo565.org