Skip to content

Crank souvlaki to 0.4.4 fixing OpenBSD support#218

Merged
jpochyla merged 1 commit intojpochyla:masterfrom
klemensn:souvlaki-update
Nov 18, 2021
Merged

Crank souvlaki to 0.4.4 fixing OpenBSD support#218
jpochyla merged 1 commit intojpochyla:masterfrom
klemensn:souvlaki-update

Conversation

@klemensn
Copy link
Copy Markdown
Contributor

No description provided.

@jpochyla jpochyla merged commit b177925 into jpochyla:master Nov 18, 2021
@klemensn klemensn deleted the souvlaki-update branch November 18, 2021 19:08
@jpochyla
Copy link
Copy Markdown
Owner

Oops I'm really sorry, of course I forgot to remove the souvlaki pin from 53c9709 and broke this. We've kept souvlaki at 0.4.0 because it drags a lot of needless dependencies with it, thanks to zbus :/ I'll figure something out, but bundling an async runtime because of a dbus library for media key support sounds terrible.

@Sinono3
Copy link
Copy Markdown
Contributor

Sinono3 commented Jan 2, 2022

Just want to make a quick update on this. I didn't realize how much dependencies zbus would bring in, the library's proc macros were very attractive and I didn't think about the consequences (I also messed up in not changing the minor version, causing some breakage here and there)

But. good news! :)

Souvlaki reverted to dbus-crossroads, dropping the zbus dependency and the async usage. Just compiled psst with the new version and it works correctly for me in Linux (no major changes have been made in Windows and macOS)

@klemensn klemensn mentioned this pull request Jan 5, 2022
@jpochyla
Copy link
Copy Markdown
Owner

jpochyla commented Jan 6, 2022

Wow, thanks a lot @Sinono3, that's great! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants