Skip to content

chore: Build Windows ICO using ImageMagick#229

Merged
jpochyla merged 7 commits intojpochyla:masterfrom
jstarpl:fix/issue-227
Dec 10, 2021
Merged

chore: Build Windows ICO using ImageMagick#229
jpochyla merged 7 commits intojpochyla:masterfrom
jstarpl:fix/issue-227

Conversation

@jstarpl
Copy link
Copy Markdown
Contributor

@jstarpl jstarpl commented Dec 9, 2021

This PR adds a step to use ImageMagick to build the Windows ICO file.

@jstarpl jstarpl changed the title fix: Make Windows builds work again in GH Actions fix: Build Windows ICO using ImageMagick Dec 9, 2021
@jstarpl jstarpl changed the title fix: Build Windows ICO using ImageMagick chore: Build Windows ICO using ImageMagick Dec 9, 2021
@jpochyla
Copy link
Copy Markdown
Owner

jpochyla commented Dec 9, 2021

Uuu, thanks a lot @jstarpl! Unfortunately it seems the Windows build is failing on the ICO step (with magick not found).

@jstarpl
Copy link
Copy Markdown
Contributor Author

jstarpl commented Dec 9, 2021

I'm gonna look into it some more and try to figure out why it can't find ImageMagick.

@jstarpl
Copy link
Copy Markdown
Contributor Author

jstarpl commented Dec 9, 2021

I think the problem was that the "desktop" way of setting the PATH across steps is no longer supported. Supposedly, this is how it should be done: https://stackoverflow.com/questions/60169752/how-to-update-the-path-in-a-github-action-workflow-file-for-a-windows-latest-hos . I tried to apply that solution, let's see if it works now.

@jstarpl
Copy link
Copy Markdown
Contributor Author

jstarpl commented Dec 10, 2021

Learning PowerShell is fun! /sarcasm. I think the correct string should now be written to the PATH GitHub variable.

@jstarpl
Copy link
Copy Markdown
Contributor Author

jstarpl commented Dec 10, 2021

Learning by doing. Hopefully now it's correct.

@jstarpl
Copy link
Copy Markdown
Contributor Author

jstarpl commented Dec 10, 2021

Okay, the PATH works now, I just missed a line creating a 32-bit 16x16 version.

@jstarpl
Copy link
Copy Markdown
Contributor Author

jstarpl commented Dec 10, 2021

Finally! The Windows build seems to work fine.

@jpochyla
Copy link
Copy Markdown
Owner

Thanks a lot @jstarpl! Merging <3

@jpochyla jpochyla merged commit f6eb1fe into jpochyla:master Dec 10, 2021
@jpochyla jpochyla mentioned this pull request Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants