icons: Switch to conventional track skip icons#252
Merged
jpochyla merged 1 commit intojpochyla:masterfrom Mar 19, 2022
Merged
Conversation
Collaborator
|
Could you post a screenshot of the new svgs? |
Contributor
Author
|
|
Owner
|
Hi @jforberg, thanks for the contribution! Can you please fill the names of the icons in the comment on top of the respective const? Merging afterwards. |
Change the track skipping buttons from ⏩, ⏪ to ⏭, ⏮. The shapes are from the SF Pro font, same as the old icons. The icons ⏩, ⏪ conventionally denote fast-forward and rewind (seeking within a single track). By contrast, the icons ⏭, ⏮ denote track skipping (moving to the next or previous track). See for instance: https://en.wikipedia.org/wiki/Media_control_symbols#Symbols
Contributor
Author
|
Hi @jpochyla, I updated the icon names as requested |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the track skipping buttons from ⏩, ⏪ to ⏭, ⏮. The shapes are
from the SF Pro font, same as the old icons.
The icons ⏩, ⏪ conventionally denote fast-forward and rewind (seeking
within a single track). By contrast, the icons ⏭, ⏮ denote track
skipping (moving to the next or previous track).
See for instance: https://en.wikipedia.org/wiki/Media_control_symbols#Symbols