Stop playback on stop command#261
Merged
jpochyla merged 1 commit intojpochyla:masterfrom Mar 12, 2022
Merged
Conversation
forslund
force-pushed
the
pause-on-stop
branch
from
cce0bcc to
f4cba1d
Compare
Contributor
Author
|
Read the code some more...perhaps it's better to run a Edit: Updated the PR, for reference my first attempt was to call the pause method when stop was received in addition to the stop code. |
forslund
force-pushed
the
pause-on-stop
branch
from
f4cba1d to
9805367
Compare
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the audio playback continues when the stop command is received in the player. To me this was quite counter-intuitive, and I think the playback should stop directly.
This adds a call to
self.audio_output_sink.stop()when the stop-command is received.This can easily be tested using the cli-client where "s" will not do anything.