feat: implement scrollable volume slider#266
Merged
Insprill merged 5 commits intojpochyla:masterfrom Jan 12, 2023
Merged
Conversation
Owner
|
Hi, thanks a lot! I'll be back to keyboard after a month of travels next week, so I'll jump on this asap. |
|
What happened with this feature? :( |
Adds the SliderScrollScale to the config, and exposes the basic scale in the prefrences menu. It also moves around some logic to allow scrollable sliders anywhere instead of only on the volume bar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From Spotify & YouTube, I missed scrolling to change the volume, so I implemented it. I added one field to the config
with defaults
You can also invert the scroll direction by making the x or y field negative