very basic ico creation out of github actions#282
Merged
jpochyla merged 4 commits intojpochyla:masterfrom May 19, 2022
Merged
Conversation
Owner
|
Hi! Thanks a lot for the PR, and sorry for the delay. Can you please rebase on top of master? Merging afterwards! |
Contributor
Author
|
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix #259
Note I didn't add all of the other variations of resolution and color sizes, since from ico format history it seems that from Windows Vista resolution: 256x256 is supported with all colors. Also that is the point at which png are supported, so I don't think smaller icons are necessary.