Quit app when the main window is closed#344
Merged
jpochyla merged 1 commit intojpochyla:masterfrom Oct 12, 2022
Insprill:fix/249
Merged
Quit app when the main window is closed#344jpochyla merged 1 commit intojpochyla:masterfrom Insprill:fix/249
jpochyla merged 1 commit intojpochyla:masterfrom
Insprill:fix/249
Conversation
Insprill
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures all child windows are closed and the app closes when the main window is closed. Fixes #249.
I currently call the
CLOSE_ALL_WINDOWSandQUIT_APPcommands because on Windows theQUIT_APPcommand takes a while to actually quit, and I'm not sure ifCLOSE_ALL_WINDOWSworks the same way on other platforms as it does Windows. Testing on other platforms to see if both are necessary would be appreciated!