Skip to content

Fix queue behaviour when switching away from random#358

Merged
Insprill merged 2 commits intojpochyla:masterfrom
bivhitscar:fix_queue_behaviour_switching
Jan 12, 2023
Merged

Fix queue behaviour when switching away from random#358
Insprill merged 2 commits intojpochyla:masterfrom
bivhitscar:fix_queue_behaviour_switching

Conversation

@bivhitscar
Copy link
Copy Markdown
Contributor

Playback should proceed according to the currently selected queue behaviour. The implementation of random/shuffle was causing other options to fail if it had been previously selected.

This change restores the actual playlist position when switching queue behaviours, allowing for correct queue advancement at the end of the currently playing item.

To reproduce the original problem:
Open a playlist/album.
Select and play any item other than number 1*.
Select the random queue behaviour.
Select the loop all behaviour.
Click the skip to next item button.
When play advances to the next item, it will not be as expected (item 2 will probably play).

*The problem still exists from here, but is harder to spot.

Comment thread psst-core/src/player/queue.rs
@Insprill Insprill merged commit cef9770 into jpochyla:master Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants