Fix queue behaviour when switching away from random#358
Merged
Insprill merged 2 commits intojpochyla:masterfrom Jan 12, 2023
Merged
Fix queue behaviour when switching away from random#358Insprill merged 2 commits intojpochyla:masterfrom
Insprill merged 2 commits intojpochyla:masterfrom
Conversation
Insprill
requested changes
Jan 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Playback should proceed according to the currently selected queue behaviour. The implementation of random/shuffle was causing other options to fail if it had been previously selected.
This change restores the actual playlist position when switching queue behaviours, allowing for correct queue advancement at the end of the currently playing item.
To reproduce the original problem:
Open a playlist/album.
Select and play any item other than number 1*.
Select the random queue behaviour.
Select the loop all behaviour.
Click the skip to next item button.
When play advances to the next item, it will not be as expected (item 2 will probably play).
*The problem still exists from here, but is harder to spot.