gui: Avoid unwrapping when fetching images#374
Merged
Insprill merged 2 commits intojpochyla:masterfrom Feb 11, 2023
Merged
Conversation
On bad connections, one timeout can cause the whole app to crash
Contributor
Author
|
thanks for the style fix :) |
Insprill
pushed a commit
that referenced
this pull request
Mar 22, 2023
* Safer error-handling mechanism Hi, this is my first time writing Rust, please go easy on me 🙂 Could you make sure I did it correct? I won't be offended if it's not any good. This error was I think similar to the one found in #374 The error was as follows and it would cause the app to crash and shutdown: > thread 'main' panicked at 'called Result::unwrap() on an Err value: "SendError(..)"', psst-gui/src/controller/playback.rs:219:51 * Update playback.rs * Update playback.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On bad connections, one timeout can cause the whole app to crash